Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 83 to Chromium 84 (1.11.x). #10551

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Conversation

mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Jul 3, 2020

Fixes #10364
Fixes #10186
Related PR: brave/brave-core#5996

Uplift from #10363

Also, uplifts:

#10560

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 1.11.x - Beta milestone Jul 3, 2020
@mkarolin mkarolin self-assigned this Jul 3, 2020
@mkarolin mkarolin marked this pull request as ready for review July 6, 2020 21:19
mkarolin and others added 2 commits July 7, 2020 12:34
Upgrade from Chromium 83 to Chromium 84
Remove string replacements as they are done in Python now
@mkarolin mkarolin changed the title WIP: Upgrade from Chromium 83 to Chromium 84 (1.11.x). Upgrade from Chromium 83 to Chromium 84 (1.11.x). Jul 7, 2020
@mkarolin mkarolin requested a review from a team July 7, 2020 18:53
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.11.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 08ccabf into 1.11.x Jul 8, 2020
@kjozwiak kjozwiak deleted the cr84-1.11.x branch July 8, 2020 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants